[ 
https://issues.apache.org/jira/browse/TINKERPOP-1671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16001045#comment-16001045
 ] 

ASF GitHub Bot commented on TINKERPOP-1671:
-------------------------------------------

Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/605
  
    All tests pass with `docker/build.sh -t -n -i`
    
    VOTE +1


> Default method for RemoteConnection.submitAsync throws exception from submit 
> on calling thread instead of failing the future
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TINKERPOP-1671
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1671
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: process
>    Affects Versions: 3.2.4
>            Reporter: Andy Tolbert
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> If a {{RemoteConnection}} implementation does not override {{submitAsync}}, 
> the default method is used which simply wraps {{submit}} in a future.  
> One downside of this is that if an exception is thrown by {{submit}}, the 
> exception is thrown on the calling thread instead of failing the future.
> Failing the future would be more preferable for consistencies sake, otherwise 
> client code would need to consider that an exception could be thrown on the 
> calling thread or that the future may fail.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to