[
https://issues.apache.org/jira/browse/TINKERPOP-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16018243#comment-16018243
]
ASF GitHub Bot commented on TINKERPOP-1618:
-------------------------------------------
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/608
TINKERPOP-1618 Removed dependence on groovy for gremlin-python
https://issues.apache.org/jira/browse/TINKERPOP-1618
Executed code generation with the gmavenplus plugin and the Groovy
templating library. This approach also gets the files generated in a much
earlier (and more correct) phase of the maven life cycle which may be important
to other GLVs using this as a pattern. It may yet mean better build workflow
options for gremlin-python.
Builds with `docker/build.sh -t -i -n`
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1618
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/608.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #608
----
commit 7e8b481f43c2ad744ccabee994ac47a87182fdc4
Author: Stephen Mallette <[email protected]>
Date: 2017-05-19T18:37:27Z
TINKERPOP-1618 Removed dependence on groovy for gremlin-python
Executed code generation with the gmaven plugin and the Groovy templating
library. This approach also gets the files generated in a much earlier (and
more correct) phase of the maven life cycle which may be important to other
GLVs using this as a pattern.
----
> Remove groovy dependency from gremlin-python
> --------------------------------------------
>
> Key: TINKERPOP-1618
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1618
> Project: TinkerPop
> Issue Type: Improvement
> Components: language-variant
> Affects Versions: 3.2.3
> Reporter: stephen mallette
> Assignee: stephen mallette
> Priority: Minor
>
> {{gremlin-python}} currently depends on groovy for its code generation needs.
> This dependency could probably be removed in favor of the scripts being
> executed as part of the gmavenplus plugin directly in the pom.xml. In this
> way the gremlin-python jar would no longer have a dependency on groovy.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
