[
https://issues.apache.org/jira/browse/TINKERPOP-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16019850#comment-16019850
]
ASF GitHub Bot commented on TINKERPOP-1675:
-------------------------------------------
GitHub user tolbertam opened a pull request:
https://github.com/apache/tinkerpop/pull/609
TINKERPOP-1675 Throw underlying unchecked exception in processNextStart
For consistency with previous behavior, if an unchecked exception is set on
the returned future throw that instead of the wrapped CompletionException.
For [TINKERPOP-1675](https://issues.apache.org/jira/browse/TINKERPOP-1675).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tolbertam/tinkerpop TINKERPOP-1675
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/609.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #609
----
commit 916ba148cf358f531629efa30c6174e85c676001
Author: Andrew Tolbert <[email protected]>
Date: 2017-05-22T17:14:15Z
TINKERPOP-1675 Throw underlying unchecked exception in processNextStart
For consistency with previous behavior, if an unchecked exception is
set on the returned future throw that instead of the wrapped
CompletionException.
----
> RemoteStep#processNextStart() throws CompletionException instead of
> underlying exception
> ----------------------------------------------------------------------------------------
>
> Key: TINKERPOP-1675
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1675
> Project: TinkerPop
> Issue Type: Bug
> Components: process
> Affects Versions: 3.2.4
> Reporter: Andy Tolbert
>
> There is a slight behavior change in TinkerPop 3.2.4 as it pertains to an
> exception thrown when processing a traversal on a remote traversal source.
> In 3.2.3, if an unchecked exception is thrown, it is propagated directly to
> the user.
> However, in 3.2.4, since RemoteStep#processNextStart() now calls
> RemoteStep#promise() and joins on the returning futures result, if the future
> fails a {{CompletionException}} is thrown wrapping the cause, instead of the
> cause itself.
> For consistency, if that exception is an unchecked exception, it should be
> thrown directly, otherwise it should be wrapped in an
> {{IllegalStateException}} as it did before.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
