[ 
https://issues.apache.org/jira/browse/TINKERPOP-1687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16042804#comment-16042804
 ] 

David Pitera commented on TINKERPOP-1687:
-----------------------------------------

I just noticed this commit: 
https://github.com/apache/tinkerpop/commit/b689deb1dd1a0c745966a1ed5f8e7e3b2d543af2

which makes the MetricManager rely on the GremlinServer which is in the 
gremlin-server module, so I am not sure I'll be able to move the Manager into 
gremlin-core anyway. I will have to think a bit about it, because the code I 
need to instrument is in the gremlin-groovy project 
https://github.com/apache/tinkerpop/blob/master/gremlin-groovy/src/main/java/org/apache/tinkerpop/gremlin/groovy/engine/GremlinExecutor.java#L249-L282

> Record metrics around how long it gremlin script executions sit in executor 
> queue waiting to be executed.
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: TINKERPOP-1687
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1687
>             Project: TinkerPop
>          Issue Type: Improvement
>    Affects Versions: 3.2.4
>            Reporter: David Pitera
>            Priority: Minor
>              Labels: breaking
>             Fix For: 3.2.5
>
>
> The issue will be breaking because I will be moving the MetricManager into 
> the gremlin-core project from the gremlin-server project for easier use 
> across the project. Therefore whoever is using the MetricManager will need to 
> update their location from where they grab it.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to