Github user okram commented on a diff in the pull request:

    https://github.com/apache/tinkerpop/pull/621#discussion_r121702575
  
    --- Diff: 
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/TraversalRing.java
 ---
    @@ -62,6 +62,10 @@ public void addTraversal(final Traversal.Admin<A, B> 
traversal) {
             this.traversals.add(traversal);
         }
     
    +    public void setTraversal(final int index, final Traversal.Admin<A, B> 
traversal) {
    --- End diff --
    
    Why do a `setTraversal()`? Why not do a `replaceTraversal()`? Then it will 
be consistent with usage and there is no indexing `i` stuff needed. And this 
will clean up your code so you don't need the `for()`-loop with `break` and 
`i++`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to