[ 
https://issues.apache.org/jira/browse/TINKERPOP-741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16054314#comment-16054314
 ] 

ASF GitHub Bot commented on TINKERPOP-741:
------------------------------------------

GitHub user spmallette opened a pull request:

    https://github.com/apache/tinkerpop/pull/633

    TINKERPOP-741 (master)

    https://issues.apache.org/jira/browse/TINKERPOP-741
    
    Removed deprecated  methods related to transaction retry.  Builds with `mvn 
clean install`.
    
    VOTE +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-741-master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/633.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #633
    
----
commit eba0a2c0a3dbb8ea1bb4d5358b8c7445cad15c85
Author: Stephen Mallette <[email protected]>
Date:   2017-06-19T15:45:32Z

    TINKERPOP-741 Deprecated Transaction.submit(Function)

commit 21102e4fa86c1094a36e44bba8147d27f3da7628
Author: Stephen Mallette <[email protected]>
Date:   2017-06-19T15:52:04Z

    Merge branch 'TINKERPOP-741' into TINKERPOP-741-master

commit 80822ee52c7eb500e38a444d44f98b5469c496e6
Author: Stephen Mallette <[email protected]>
Date:   2017-06-19T16:15:33Z

    TINKERPOP-741 Removed deprecated transaction retry methods

commit 21bc4d85945cdd9beeeaedd92eb2769d75de53ba
Author: Stephen Mallette <[email protected]>
Date:   2017-06-19T16:24:47Z

    TINKERPOP-741 Added upgrade docs around deprecation

----


> Remove Options For Transaction Retry
> ------------------------------------
>
>                 Key: TINKERPOP-741
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-741
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: structure
>    Affects Versions: 3.0.2-incubating
>            Reporter: stephen mallette
>
> Submitting a transactional workload for automatic retry currently looks like 
> this:
> {code}
> public <R> Workload<R> submit(final Function<Graph, R> work);
> {code}
> but that doesn't take into account relatively recent changes that allow 
> mutation operations to execute over a {{Traversal}}.  It also doesn't account 
> for workload constructed over multiple requests in a session to Gremlin 
> Server too well.
> Maybe we do something like:
> {code}
> public <R> Workload<R> submit(final Function<Graph, R>... work);
> public <R> Workload<R> submit(final Function<TraversalSource, R>... work);
> public <R> Workload<R> submit(final Traversal... work);
> {code}
> I suppose it might need to return a {{List<R>}} or something like that so 
> that each piece of the transaction could maintain its own result.
> With respect to Gremlin Server and in-session requests, a driver could 
> automate transaction retry by inserting scripts to a list variable on the 
> server side until client-side {{commit()}} at which point that list could be 
> {{submit}} for retry.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to