[
https://issues.apache.org/jira/browse/TINKERPOP-1004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16056211#comment-16056211
]
ASF GitHub Bot commented on TINKERPOP-1004:
-------------------------------------------
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/637
TINKERPOP-1004 Expand usage of TransactionException
https://issues.apache.org/jira/browse/TINKERPOP-1004
`TransactionException` is no longer bound to usage by
`AbstractTransaction`. Prescribed a more general usage of it with the
Transaction interface.
Builds with `mvn clean install -DincludeNeo4j && mvn verify -pl
gremlin-server -DskipIntegrationTests=false -DincludeNeo4j`
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1004
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/637.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #637
----
commit eb0eddca04050cb48d1262c7ff3bc28354f558c6
Author: Stephen Mallette <[email protected]>
Date: 2017-06-20T16:57:04Z
TINKERPOP-1004 Expand usage of TransactionException
TransactionException is no longer bound to usage by AbstractTransaction.
Precribed a more general usage of it with the Transaction interface.
----
> Make Transaction.commit() failures consistent across implementations.
> ---------------------------------------------------------------------
>
> Key: TINKERPOP-1004
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1004
> Project: TinkerPop
> Issue Type: Improvement
> Components: structure
> Affects Versions: 3.0.2-incubating
> Reporter: Dylan Millikin
> Labels: breaking
>
> Currently {{commit()}} can fail when implementations throw exceptions. These
> exceptions aren't consistent and are very implementation specific. It would
> be good to abstract this and provide TP specific exceptions for this (while
> bubbling the original exceptions).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
