[
https://issues.apache.org/jira/browse/TINKERPOP-999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16056640#comment-16056640
]
ASF GitHub Bot commented on TINKERPOP-999:
------------------------------------------
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/638#discussion_r123119092
--- Diff:
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/GremlinServer.java
---
@@ -108,54 +108,24 @@ public GremlinServer(final Settings settings) {
workerGroup = new NioEventLoopGroup(settings.threadPoolWorker,
threadFactoryWorker);
}
- serverGremlinExecutor = new ServerGremlinExecutor<>(settings,
null, workerGroup, EventLoopGroup.class);
+ serverGremlinExecutor = new ServerGremlinExecutor(settings, null,
workerGroup, null);
--- End diff --
Looks like the 4th parameter is no longer needed. Since the PR targets
`master/`, it would be fine to remove it altogether, no?
> ServerGremlinExecutor construction need not use generics for ExecutorService
> ----------------------------------------------------------------------------
>
> Key: TINKERPOP-999
> URL: https://issues.apache.org/jira/browse/TINKERPOP-999
> Project: TinkerPop
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.1.0-incubating
> Reporter: stephen mallette
> Assignee: stephen mallette
> Priority: Minor
> Labels: breaking
> Fix For: 3.3.0
>
>
> See TINKERPOP3-912 for more information but the {{ServerGremlinExecutor}}
> will always need be bound to Netty so there's not much need for use of
> generics in the class definition. Remove unecessary constructors and perhaps
> scope them internal as this class will not be publicly constructed. This
> will be a breaking change.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
