Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/638#discussion_r123125481
--- Diff:
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/GremlinServer.java
---
@@ -108,54 +108,24 @@ public GremlinServer(final Settings settings) {
workerGroup = new NioEventLoopGroup(settings.threadPoolWorker,
threadFactoryWorker);
}
- serverGremlinExecutor = new ServerGremlinExecutor<>(settings,
null, workerGroup, EventLoopGroup.class);
+ serverGremlinExecutor = new ServerGremlinExecutor(settings, null,
workerGroup, null);
--- End diff --
i think you're right. I sorta wonder if the second parameter is of value.
Gremlin Server is the only thing that really creates that ExecutorService.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
