[
https://issues.apache.org/jira/browse/TINKERPOP-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057328#comment-16057328
]
Jorge Bay commented on TINKERPOP-1552:
--------------------------------------
I've found an issue regarding the API of the C# GLV:
{{GraphSONReader}} class and {{IGraphSONDeserializer}} interface uses
{{JToken}} as parameter on public methods, which is a third-party type from
[Newtonsoft's Json.NET|http://www.newtonsoft.com/json].
We can use a third-party library as a dependency, but exposing a type from
other library in our API will tightly couple our library to the 3rd party
library.
The solution would be to parse the json using Json.NET (as is) but use
{{dynamic}} in our public API, which is a good fit for parsed json.
> C# Gremlin Language Variant
> ---------------------------
>
> Key: TINKERPOP-1552
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1552
> Project: TinkerPop
> Issue Type: Improvement
> Components: language-variant
> Affects Versions: 3.2.3
> Reporter: Jorge Bay
> Assignee: stephen mallette
>
> It would be nice to have a C# GLV that runs under .NET Framework 4.5+ and
> .NET Core.
> The maven build could use the Exec Maven Plugin to exec .NET Core's [dotnet
> test|https://www.microsoft.com/net/core#macos] command.
> Some requirements, from the mailing list (edited):
> {quote}
> 1. The GLV should keep in line with class/method names of the java API
> where possible to ensure consistency of feel across languages.
> 2. There needs to be adequate tests (we're still discussing the approach to
> testing GLVs and i think that needs to be tackled sooner than later as more
> GLVs start to come in). Those tests should produce xunit style output
> unless there is some good reason not to.
> 3. There needs to be adequate documentation (e.g. Reference docs)
> 4. The build/deploy process needs to be bound to maven which might be one of
> the trickier bits to deal with.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
