[
https://issues.apache.org/jira/browse/TINKERPOP-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16059230#comment-16059230
]
ASF GitHub Bot commented on TINKERPOP-1550:
-------------------------------------------
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/628#discussion_r123489196
--- Diff: gremlin-server/pom.xml ---
@@ -63,10 +63,12 @@ limitations under the License.
<dependency>
<groupId>com.codahale.metrics</groupId>
<artifactId>metrics-graphite</artifactId>
+ <optional>true</optional>
--- End diff --
All of metrics is under `<dependencyManagement>` in the root pom.xml so the
version is defined there:
https://github.com/apache/tinkerpop/blob/268333b4778c87ce6c2429eda97e3e1adc7757e3/pom.xml#L602-L642
I don't think it needs to be specified again.
> Make Graphite and Ganglia optional dependencies
> -----------------------------------------------
>
> Key: TINKERPOP-1550
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1550
> Project: TinkerPop
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.2.3
> Reporter: stephen mallette
> Assignee: stephen mallette
> Priority: Minor
> Fix For: 3.3.0
>
>
> This ticket started out as "Provide a way to not specifically depend on and
> package the various reporters tied to the Gremlin Server `MetricsManager`",
> but while that is a nice idea, it ends up being more complicated than what is
> required and at this point I haven't really heard of any users asking for the
> ability to drop in other reporters.
> Anyway, Ganglia/Graphite should be made optional dependencies as they aren't
> really required for operation of Gremlin Server and it should be up to the
> user to decide which they want to use and include. Plus, this gets rid of the
> ugly problem of an LGPL dependency which we used to just exclude and thus
> force the user to copy in manually. As a result, we kinda added stuff to the
> distribution which didn't work out of the box anyway. Better to just avoid
> the whole issue and not include them.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
