Github user okram commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/621#discussion_r123753801
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/GroupStep.java
---
@@ -79,6 +79,14 @@ public void modulateBy(final Traversal.Admin<?, ?>
kvTraversal) {
}
@Override
+ public void replaceLocalChild(final Traversal.Admin<?, ?>
oldTraversal, final Traversal.Admin<?, ?> newTraversal) {
+ if (null != this.keyTraversal &&
this.keyTraversal.equals(oldTraversal))
+ this.keyTraversal = this.integrateChild(newTraversal);
+ else if (null != this.valueTraversal &&
this.valueTraversal.equals(oldTraversal))
--- End diff --
You are thinking of your strategy only and not about the general semantics
of `replaceLocalChild()`. Your additions to `TraversalParent` should not just
be predicated on your specific `ByModulatorStrategy`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
