[
https://issues.apache.org/jira/browse/TINKERPOP-1603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069840#comment-16069840
]
ASF GitHub Bot commented on TINKERPOP-1603:
-------------------------------------------
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/646
TINKERPOP-1603 Remove deprecated code
This pull request covers a series of related "deprecation removal" in a
continued effort to remove related dead code from 3.3.0:
https://issues.apache.org/jira/browse/TINKERPOP-1603 (byte array for sasl
argument option)
https://issues.apache.org/jira/browse/TINKERPOP-1481 (reconectInitialDelay
config option)
https://issues.apache.org/jira/browse/TINKERPOP-1028 (sessionId setting on
connection pool)
https://issues.apache.org/jira/browse/TINKERPOP-1275 (:remote config
timeout max)
https://issues.apache.org/jira/browse/TINKERPOP-1699 (useMapperFromGraph
for serializer)
https://issues.apache.org/jira/browse/TINKERPOP-1700 (embedTypes for
GraphSON)
https://issues.apache.org/jira/browse/TINKERPOP-1651 (bin/gremlin.sh
script.groovy)
I did a full build with docker and all is good.
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1603
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/646.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #646
----
commit 7a29c6ba1a73315c53b8002d41e7892963b3e8b5
Author: Stephen Mallette <[email protected]>
Date: 2017-06-26T18:28:09Z
TINKERPOP-1603 Removed support for byte array sasl argument
commit cd1b457cb9c8df1bbd99076209bfaf636f6fab37
Author: Stephen Mallette <[email protected]>
Date: 2017-06-26T19:10:58Z
TINKERPOP-1481 Removed previously deprecated reconnectInitialDelay
commit 90c9a582faa1806399865a476e8202492cff2a23
Author: Stephen Mallette <[email protected]>
Date: 2017-06-26T19:57:12Z
TINKERPOP-1028 Removed previously deprecated ConnectionPoolSettings session
settings
commit 7c04cee8834233f977547d1fe5f19a94fd97a46a
Author: Stephen Mallette <[email protected]>
Date: 2017-06-26T20:01:35Z
TINKERPOP-1275 Removed previously deprecated max setting for :remote
commit deeeb877f2603aa2283ea551d0989b9e36d72406
Author: Stephen Mallette <[email protected]>
Date: 2017-06-26T22:50:30Z
TINKERPOP-1275 Removed test for max timeout on :remote
commit 851a8debe859b9d6a39f4ce8461db7138c2246a0
Author: Stephen Mallette <[email protected]>
Date: 2017-06-29T16:16:33Z
TINKERPOP-1699 Removed deprecated userMapperFromGraph option
Conflicts:
CHANGELOG.asciidoc
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/ser/AbstractGraphSONMessageSerializerV1d0.java
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/ser/AbstractGryoMessageSerializerV1d0.java
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/AbstractChannelizer.java
commit 6b50de534793807b1e8d885f02524bfb62de0410
Author: Stephen Mallette <[email protected]>
Date: 2017-06-29T18:06:36Z
TINKERPOP-1700 Removed previously deprecated embedTypes option for GraphSON
commit 1c39d670a216a5ae694f2551504e90a826de6595
Author: Stephen Mallette <[email protected]>
Date: 2017-06-29T19:05:02Z
TINKERPOP-1651 Removed ability to pass a script to gremlin.sh without a flag
This feature was deprecated long ago, but we tried to maintain
compatibility up until now
commit 6f5ae81657a544ae571f9931c576215395a0066f
Author: Stephen Mallette <[email protected]>
Date: 2017-06-29T19:11:38Z
Removed some tokens that are no longer in use.
They were part of ControlOpProcessor which was deprecated and removed a
long while back.
commit 8105faa1f84062bff7639e0ebd366d3e7d12cc90
Author: Stephen Mallette <[email protected]>
Date: 2017-06-29T20:32:38Z
TINKERPOP-1699 Removed more instance of useMapperFromGraph
Somehow these didn't get removed previously. Intellij didn't find them
somehow when I had searched - weird.
----
> Remove support for SASL byte array in protocol
> ----------------------------------------------
>
> Key: TINKERPOP-1603
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1603
> Project: TinkerPop
> Issue Type: Improvement
> Components: driver, server
> Affects Versions: 3.2.3
> Reporter: stephen mallette
> Assignee: stephen mallette
> Priority: Minor
> Labels: breaking
> Fix For: 3.3.0
>
>
> Support for sending SASL arguments as a byte array has been deprecated in
> 3.2.4 with TINKERPOP-1600. Remove that aspect of the protocol.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
