[
https://issues.apache.org/jira/browse/TINKERPOP-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16079613#comment-16079613
]
ASF GitHub Bot commented on TINKERPOP-1385:
-------------------------------------------
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/656
TINKERPOP-1385 Bound profile test assertions to TinkerGraph
https://issues.apache.org/jira/browse/TINKERPOP-1385
Assertions were too stringent for graph providers who had complex
strategies.
All tests pass with `docker/build.sh -t -n -i`
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1385
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/656.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #656
----
commit d27fc7d2465af97aa583cb6c072391273286d322
Author: Stephen Mallette <[email protected]>
Date: 2017-07-09T13:54:21Z
TINKERPOP-1385 Bound profile test assertions to TinkerGraph
Assertions were too stringent for graph providers who had complex
strategies.
----
> Refactor Profiling test cases
> -----------------------------
>
> Key: TINKERPOP-1385
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1385
> Project: TinkerPop
> Issue Type: Bug
> Components: test-suite
> Affects Versions: 3.2.1
> Reporter: Matthias Broecheler
> Assignee: stephen mallette
> Priority: Minor
>
> The following test cases make assumptions about the number of steps in the
> traversal. A particular TinkerPop implementation may have strategies that
> change those steps and/or add additional steps to the traversal, thus
> breaking those tests.
> The tests should be rewritten/adjusted to be more lenient and accommodate
> additional implementation strategies.
> {code}
> org.apache.tinkerpop.gremlin.process.traversal.step.map.ProfileTest$Traversals
> .g_V_sideEffectXThread_sleepX10XX_sideEffectXThread_sleepX5XX_profileXmetricsX
> .g_V_whereXinXcreatedX_count_isX1XX_name_profile
> .g_V_whereXinXcreatedX_count_isX1XX_name_profileXmetricsX
> .g_V_sideEffectXThread_sleepX10XX_sideEffectXThread_sleepX5XX_profile
> org.apache.tinkerpop.gremlin.structure.SerializationTest$GraphSONTest.shouldSerializeTraversalMetrics
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
