[ 
https://issues.apache.org/jira/browse/TINKERPOP-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16084095#comment-16084095
 ] 

ASF GitHub Bot commented on TINKERPOP-1552:
-------------------------------------------

Github user jorgebay commented on the issue:

    https://github.com/apache/tinkerpop/pull/670
  
    I'm looking into the `g_V_HasXname_markoX_ValueMap_Next` failure on 
gremlin-dotnet, it looks like the generation process was producing:
    
    ```
    public GraphTraversal<S, IDictionary<string, E2>> ValueMap<E2>(params 
object[] args)
    ```
    
    and now:
    
    ```
    public GraphTraversal< S , IDictionary<object, E2> > ValueMap<E2> (params 
object[] args)
    ```
    
    for java, both signatures exists (with different parameters). The safest 
route would be to use a second type parameter:
    ```
    public GraphTraversal< S , IDictionary<K, V> > ValueMap<K, V> (params 
object[] args)
    ```
    I'll try to find a solution. Afterwards, we should look into ways to do 
.NET generation as deterministic as possible.


> C# Gremlin Language Variant
> ---------------------------
>
>                 Key: TINKERPOP-1552
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1552
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: language-variant
>    Affects Versions: 3.2.3
>            Reporter: Jorge Bay
>            Assignee: stephen mallette
>
> It would be nice to have a C# GLV that runs under .NET Framework 4.5+ and 
> .NET Core.
> The maven build could use the Exec Maven Plugin to exec .NET Core's [dotnet 
> test|https://www.microsoft.com/net/core#macos] command.
> Some requirements, from the mailing list (edited):
> {quote}
> 1. The GLV should keep in line with class/method names of the java API
> where possible to ensure consistency of feel across languages.
> 2. There needs to be adequate tests (we're still discussing the approach to
> testing GLVs and i think that needs to be tackled sooner than later as more
> GLVs start to come in). Those tests should produce xunit style output
> unless there is some good reason not to.
> 3. There needs to be adequate documentation (e.g. Reference docs)
> 4. The build/deploy process needs to be bound to maven which might be one of 
> the trickier bits to deal with.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to