GitHub user okram opened a pull request:

    https://github.com/apache/tinkerpop/pull/679

    TINKERPOP-1679: Detached side-effects aren't attached when remoted

    https://issues.apache.org/jira/browse/TINKERPOP-1679
    
    This was occurring because Gremlin-Python did not have serializers for the 
Graph elements. I created serializers which are of the `ReferenceXXX` form. I 
added serializer tests as well as add an `AddEdgeTest` and specific 
Gremlin-Python test for the traversal specified in the ticket. I also exposed 
two `ProjectTest` `OPT_OUTs` in `RemoteGraph`. I don't know why those were 
`OPT_OUT` as OLAP will automatically fail accordingly beyond the star graph.
    
    VOTE +1.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1679

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/679.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #679
    
----
commit 1f8239834b0c911f7d53d25a37cbee0ef26a66fc
Author: Marko A. Rodriguez <[email protected]>
Date:   2017-07-20T20:44:02Z

    added AddEdgeTest that leverages side-effect data to ensure Attachables are 
respected. Exposed PropertyTests that were OPT_OUT in RemoteGraph, but didn't 
need to be. Added a Python test to verify the specific ticket test passes 
(though tested in ProcessTestSuite). The real problem is that Python does not 
have Serializers for Graph elements. It only has deserializers. I added 
serializers of the ReferenceXXX form. This way, elements can be passed in as 
parameters. Added read/write graphson tests in Python to verify 
serialization/deserialization behavior.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to