ASF GitHub Bot commented on TINKERPOP-1747:

Github user davebshow commented on the issue:

    Yeah well there are different approaches we could have taken, e.g. leaving 
the custom reader/writer options for the v2 and v3 serializer classes, but it 
seems to me that the point of those classes is to provide consistency. In the 
less common use case where the user provides reader/writer I think that it is 
reasonably to expect that they can deal with all the required configuration 
using `GraphSONMessageSerializer`.

> Streamline inheritance for gremlin-python GraphSON serializer classes
> ---------------------------------------------------------------------
>                 Key: TINKERPOP-1747
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1747
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: language-variant
>    Affects Versions: 3.3.0
>            Reporter: David M. Brown
>             Fix For: 3.3.0
> This follows up on TINKERPOP-1427 by cleaning up the code used to create the 
> various gremlin-python GraphSON serializers for GraphSON version 2 and 3. 
> Several small changes can improve code style, reduce redundancy, and clarify 
> when custom readers and writers can be passed to the serializer (generic 
> serializer) vs. the GraphSON version specific serializers. 

This message was sent by Atlassian JIRA

Reply via email to