I found a few minor issues with the reference documentation, mainly related to 
the new Gremlin.Net GLV:
* Custom Serialization includes the following: 'by creating serializers and 
deserializers in C (or any other .NET language)'. The 'C'  should be 'C#' here. 
I don't know what went wrong here as it's correct in the asciidoc file and it 
works just fine for other occurrences of 'C#'. [1]
* The formatting and style of the Conclusion looks wrong. It's different than 
that of the remaining document. [2]
* We should probably replace Gremlin-DotNet everywhere with Gremlin.Net to stay 
consistent.

I don't know if these minor issues should halt the release. Especially the 
Gremlin.Net specific issues can also be fixed for the next release in my 
opinion.

Apart from that I built and tested Gremlin.Net without any problems. So, my 
VOTE is +0

[1] http://tinkerpop.apache.org/docs/3.2.6/reference/#_custom_serialization_2
[2] http://tinkerpop.apache.org/docs/3.2.6/reference/#conclusion

-----Ursprüngliche Nachricht-----
Von: pieter gmail [mailto:[email protected]] 
Gesendet: Dienstag, 22. August 2017 21:19
An: [email protected]
Betreff: Re: [VOTE] TinkerPop 3.2.6 Release

Ran Sqlg's own test suite and TinkerPop's structured and process test suites on 
Sqlg.
All passes.

VOTE +1

Cheers
Pieter


On 22/08/2017 20:29, Robert Dale wrote:
> VOTE +1
>
> Robert Dale
>
> On Tue, Aug 22, 2017 at 10:33 AM, Daniel Kuppitz <[email protected]> wrote:
>
>> *Validating binary distributions*
>>
>> * downloading Apache TinkerPop Gremlin 
>> (apache-tinkerpop-gremlin-console-3.2.6-bin.zip)... OK
>> * validating signatures and checksums ...
>>    * PGP signature ... OK
>>    * MD5 checksum ... OK
>>    * SHA1 checksum ... OK
>> * unzipping Apache TinkerPop Gremlin ... OK
>> * validating Apache TinkerPop Gremlin's docs ... OK
>> * validating Apache TinkerPop Gremlin's binaries ... OK
>> * validating Apache TinkerPop Gremlin's legal files ...
>>    * LICENSE ... OK
>>    * NOTICE ... OK
>> * validating Apache TinkerPop Gremlin's plugin directory ... OK
>> * validating Apache TinkerPop Gremlin's lib directory ... OK
>> * testing script evaluation ... OK
>>
>> * downloading Apache TinkerPop Gremlin 
>> (apache-tinkerpop-gremlin-server-3.2.6-bin.zip)... OK
>> * validating signatures and checksums ...
>>    * PGP signature ... OK
>>    * MD5 checksum ... OK
>>    * SHA1 checksum ... OK
>> * unzipping Apache TinkerPop Gremlin ... OK
>> * validating Apache TinkerPop Gremlin's docs ... OK
>> * validating Apache TinkerPop Gremlin's binaries ... OK
>> * validating Apache TinkerPop Gremlin's legal files ...
>>    * LICENSE ... OK
>>    * NOTICE ... OK
>> * validating Apache TinkerPop Gremlin's plugin directory ... OK
>> * validating Apache TinkerPop Gremlin's lib directory ... OK
>>
>> Validating source distribution
>>
>> * downloading Apache TinkerPop 3.2.6 (apache-tinkerpop-3.2.6-src.zip)...
>> OK
>> * validating signatures and checksums ...
>>    * PGP signature ... OK
>>    * MD5 checksum ... OK
>>    * SHA1 checksum ... OK
>> * unzipping Apache TinkerPop 3.2.6 ... OK
>> * building project ... OK
>>
>>
>>
>> VOTE: +1
>>
>> Cheers,
>> Daniel
>>
>>
>> On Tue, Aug 22, 2017 at 4:54 AM, Stephen Mallette 
>> <[email protected]>
>> wrote:
>>
>>> Hello,
>>>
>>> We are happy to announce that TinkerPop 3.2.6 is ready for release.
>>>
>>> The release artifacts can be found at this location:
>>>          https://dist.apache.org/repos/dist/dev/tinkerpop/3.2.6/
>>>
>>> The source distribution is provided by:
>>>          apache-tinkerpop-3.2.6-src.zip
>>>
>>> Two binary distributions are provided for user convenience:
>>>          apache-tinkerpop-gremlin-console-3.2.6-bin.zip
>>>          apache-tinkerpop-gremlin-server-3.2.6-bin.zip
>>>
>>> The GPG key used to sign the release artifacts is available at:
>>>      https://dist.apache.org/repos/dist/dev/tinkerpop/KEYS
>>>
>>> The online docs can be found here:
>>>          http://tinkerpop.apache.org/docs/3.2.6/ (user docs)
>>>          http://tinkerpop.apache.org/docs/3.2.6/upgrade/ (upgrade docs)
>>>          http://tinkerpop.apache.org/javadocs/3.2.6/core/ (core javadoc)
>>>          http://tinkerpop.apache.org/javadocs/3.2.6/full/ (full 
>>> javadoc)
>>>
>>> The tag in Apache Git can be found here:
>>>
>>> https://git-wip-us.apache.org/repos/asf?p=tinkerpop.git;a=tag;h=
>>> 43ed34fb10002308117b6cfabd4870d958cc2d99
>>>
>>> The release notes are available here:
>>>
>>> https://github.com/apache/tinkerpop/blob/3.2.6/
>>> CHANGELOG.asciidoc#tinkerpop-326-release-date-august-21-2017
>>>
>>> The [VOTE] will be open for the next 72 hours --- closing Friday 
>>> (August 25, 2017) at 8AM EST.
>>>
>>> My vote is +1.
>>>
>>> Thank you very much,
>>> Stephen
>>>



Reply via email to