GitHub user dkuppitz opened a pull request:

    https://github.com/apache/tinkerpop/pull/699

    TINKERPOP-1759 Improve hashcode and equals for Traverser implementations

    https://issues.apache.org/jira/browse/TINKERPOP-1759
    
    Improved `hashcode()` and `equals()` for all Traverser implementations and 
added a performance test to ensure that things don't get reverted when someone 
thinks that the hashcode implementations could be rewritten.
    
    `docker/build.sh -t -i` succeeded.
    
    VOTE: +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1759

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/699.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #699
    
----
commit d0659e379bf59a164b4c3d87cc83de545d433547
Author: Daniel Kuppitz <[email protected]>
Date:   2017-08-24T20:51:41Z

    Improved `hashcode()` and `equals()` for all Traverser implementations.

commit ea4fcdfffabdf8dc8c8a5ce11f983161f6287aef
Author: Daniel Kuppitz <[email protected]>
Date:   2017-08-25T14:13:01Z

    Added TinkerGraphPerformanceTest to ensure that the latest changes in 
hashcode() implementations don't get reverted some day.

commit f8626ce6d3f6be4dddba09b74c38b49e8d379eb7
Author: Daniel Kuppitz <[email protected]>
Date:   2017-08-25T15:43:33Z

    Improved equals() inheritance chain in Traverser implementations.
    We now have fewer checks and fewer casts. Cool!

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to