[
https://issues.apache.org/jira/browse/TINKERPOP-1759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153616#comment-16153616
]
ASF GitHub Bot commented on TINKERPOP-1759:
-------------------------------------------
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/699#discussion_r136983503
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/traverser/B_O_Traverser.java
---
@@ -62,10 +62,12 @@ public void setStepId(final String stepId) {
this.future = stepId;
}
+ protected final boolean equals(final B_O_Traverser other) {
+ return super.equals(other) && other.future.equals(this.future);
+ }
+
@Override
--- End diff --
I agree with @okram. There should be an explicit `hashCode()` so it doesn't
look like it is mistakenly forgotten.
> Improve hashcode and equals for Traverser implementations
> ---------------------------------------------------------
>
> Key: TINKERPOP-1759
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1759
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.2.6
> Reporter: Daniel Kuppitz
> Assignee: Daniel Kuppitz
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
