[
https://issues.apache.org/jira/browse/TINKERPOP-1779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16164476#comment-16164476
]
ASF GitHub Bot commented on TINKERPOP-1779:
-------------------------------------------
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/713
TINKERPOP-1779 Bump to GMavenPlus 1.6
https://issues.apache.org/jira/browse/TINKERPOP-1779
Moved embedded groovy scripts that were in the pom to their own files. They
are more manageable that way as you get some syntax highlighting/intellisense
in the IDE when they have the right file extension. It also makes the pom a bit
easier to follow. Removed a bunch of python test resources that were no longer
in use. Centralized the scripts that start/stop Gremlin Server for GLV tests so
that we don't have them copy/pasted everywhere.
All tests pass with `docker/build.sh -t -n -i`
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1779
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/713.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #713
----
commit e9801e6af60dbfbaa83a1f8b5b947451dd27092c
Author: Stephen Mallette <[email protected]>
Date: 2017-09-12T15:18:41Z
TINKERPOP-1779 Bump to GMavenPlus 1.6
Moved embedded groovy scripts that were in the pom to their own files. They
are more manageable that way as you get some syntax highlighting/intellisense
in the IDE when they have the right file extension. It also makes the pom a bit
easier to follow. Removed a bunch of python test resources that were no longer
in use. Centralized the scripts that start/stop Gremlin Server for GLV tests so
that we don't have them copy/pasted everywhere.
----
> Bump to GMavenPlus 1.6
> ----------------------
>
> Key: TINKERPOP-1779
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1779
> Project: TinkerPop
> Issue Type: Improvement
> Components: build-release
> Affects Versions: 3.2.6
> Reporter: stephen mallette
> Assignee: stephen mallette
> Priority: Minor
>
> The new version of GMavenPlus allows for a few new capabilities which we can
> make use of. Most useful is the ability to specify a groovy file for the
> {{execute}} goal. As we now make use of this goal in the GLVs pretty heavily
> we could greatly clean up the poms and make better re-use of code if that
> stuff could be pulled out into script files that could be referenced by any
> module that needs it.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
