[
https://issues.apache.org/jira/browse/TINKERPOP-1814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234354#comment-16234354
]
ASF GitHub Bot commented on TINKERPOP-1814:
-------------------------------------------
GitHub user okram opened a pull request:
https://github.com/apache/tinkerpop/pull/740
TINKERPOP-1814: Some process tests require the graph API
https://issues.apache.org/jira/browse/TINKERPOP-1814
Fixed assertions in the test cases outlined by @BrynCooke that use the
structure API when they should stick with the process API. I found more areas
than specified in the ticket. I also suspect that other process test cases will
have similar problems. As these are exposed, please just make a new ticket
accordingly - besides being monotonously boring, these are easy to fix.
VOTE +1.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1814
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/740.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #740
----
commit 608f786d354fe419a30d1453452aa9f34308f0b4
Author: Marko A. Rodriguez <[email protected]>
Date: 2017-11-01T16:19:16Z
fixed up various ProcessTestSuite tests that were using Strucure API in
assertions. Converted to be traversals for analysis.
----
> Some process tests require the graph API
> ----------------------------------------
>
> Key: TINKERPOP-1814
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1814
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.2.6
> Reporter: Bryn Cooke
> Assignee: Marko A. Rodriguez
> Priority: Major
>
> This test uses the graph API:
> https://github.com/apache/tinkerpop/blob/master/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/AddEdgeTest.java#L137-L142
> This test assumes that the reference to the vertex will be updated. It should
> at least fetch the vertex again after it has been updated, but ideally use a
> traversal for verification.
> https://github.com/apache/tinkerpop/blob/master/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/decoration/PartitionStrategyProcessTest.java#L142-L143
> These tests disable the strategies supplied by the implementing graph and
> therefore they will default to using the graph API under the hood.
> https://github.com/apache/tinkerpop/blob/master/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/CoreTraversalTest.java#L222-L261
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
