[
https://issues.apache.org/jira/browse/TINKERPOP-1813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16236038#comment-16236038
]
ASF GitHub Bot commented on TINKERPOP-1813:
-------------------------------------------
GitHub user okram opened a pull request:
https://github.com/apache/tinkerpop/pull/743
TINKERPOP-1813: Subgraph step requires the graph API
https://issues.apache.org/jira/browse/TINKERPOP-1813
This ticket wanted `SubgraphStep` to not use the structure API. This is not
something we will support in TinkerPop3. The structure API is a fundamental
layer to our step API. It was advised to the provider to simply write their own
custom `ProviderSubgraphStep` which avoids the structure API as they see fit.
However, what was accomplished in this ticket was to change `SubgraphTest` to
only use traversals (process API) in its assertions. This theme is good -- our
process test suite should never rely on the structure API (beyond
`ReferenceXXX` data).
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1813
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/743.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #743
----
commit 797937eb0c0b0fa3bc177925f4e584dfd53d8f13
Author: Marko A. Rodriguez <[email protected]>
Date: 2017-11-02T16:07:10Z
changed the SubgraphTest to use process API in assertions instead of
structure API. This is in line with the current refactor trend to make sure the
process API (and test suite) does not leak into the structure API. We need
clear boundaries between the two APIs.
----
> Subgraph step requires the graph API
> ------------------------------------
>
> Key: TINKERPOP-1813
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1813
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.2.6
> Reporter: Bryn Cooke
> Assignee: Marko A. Rodriguez
> Priority: Minor
>
> SubgraphStrategy uses the graph API to create elements in the subgraph. If a
> graph does not fully support the graph/structure API this it won't work.
> Ideally the graph mutations should use the traversal API.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
