[
https://issues.apache.org/jira/browse/TINKERPOP-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247387#comment-16247387
]
ASF GitHub Bot commented on TINKERPOP-1829:
-------------------------------------------
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/746
TINKERPOP-1829 Made detachment configurable in EventStrategy
https://issues.apache.org/jira/browse/TINKERPOP-1831
The default behavior is representative of how EventStrategy currently works
so there is no breaking change here. In the interest of avoiding breaking
changes, I didn't want to shift the API to make the change cleaner and thus
created TINKERPOP-1831 for future consideration.
All tests pass with `docker/build.sh -t -n -i`
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1829
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/746.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #746
----
commit a5f48d91069d10fe8abdcbb0559315bae10ead5f
Author: Stephen Mallette <[email protected]>
Date: 2017-11-10T11:46:10Z
TINKERPOP-1829 Made detachment configurable in EventStrategy
The default behavior is representative of how EventStrategy currently works
so there is no breaking change here. In the interest of avoiding breaking
changes, I didn't want to shift the API to make the change cleaner and thus
created TINKERPOP-1831 for future consideration.
----
> Improve flexibility of detachment for EventStrategy
> ---------------------------------------------------
>
> Key: TINKERPOP-1829
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1829
> Project: TinkerPop
> Issue Type: Improvement
> Components: structure
> Affects Versions: 3.2.6
> Reporter: stephen mallette
> Assignee: stephen mallette
>
> Currently, events raised through the {{EventStrategy}} detach elements given
> to those events. While that is a desirable approach it is not the only one.
> The method of detachment is really best left to the user as they may wish to
> use a "reference" detachment or no detachment at all.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
