[ https://issues.apache.org/jira/browse/TINKERPOP-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16249455#comment-16249455 ]
ASF GitHub Bot commented on TINKERPOP-1784: ------------------------------------------- Github user jorgebay commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/747#discussion_r150517147 --- Diff: gremlin-dotnet/src/Gremlin.Net/Driver/Remote/DriverRemoteConnection.cs --- @@ -36,15 +36,27 @@ namespace Gremlin.Net.Driver.Remote public class DriverRemoteConnection : IRemoteConnection, IDisposable { private readonly IGremlinClient _client; + private readonly string _traversalSource; /// <summary> /// Initializes a new <see cref="IRemoteConnection" />. /// </summary> /// <param name="client">The <see cref="IGremlinClient" /> that will be used for the connection.</param> /// <exception cref="ArgumentNullException">Thrown when client is null.</exception> - public DriverRemoteConnection(IGremlinClient client) + public DriverRemoteConnection(IGremlinClient client):this(client, "g") + { + } + + /// <summary> + /// Initializes a new <see cref="IRemoteConnection" />. + /// </summary> + /// <param name="client">The <see cref="IGremlinClient" /> that will be used for the connection.</param> + /// <param name="traversalSource">The name of the traversal source on the server to bind to.</param> + /// <exception cref="ArgumentNullException">Thrown when client is null.</exception> + public DriverRemoteConnection(IGremlinClient client, string traversalSource) { _client = client ?? throw new ArgumentNullException(nameof(client)); + _traversalSource = traversalSource; --- End diff -- We could add null validation in the same form: ```csharp _traversalSource = traversalSource ?? throw new ArgumentNullException(nameof(traversalSource)); ``` > Gremlin Language Test Suite > --------------------------- > > Key: TINKERPOP-1784 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1784 > Project: TinkerPop > Issue Type: Improvement > Components: test-suite > Affects Versions: 3.2.6 > Reporter: stephen mallette > Assignee: stephen mallette > > Provide for a more language agnostic test framework for the Gremlin Language > so that we can properly test GLVs. The current test suite is completely tied > to the JVM. -- This message was sent by Atlassian JIRA (v6.4.14#64029)