Github user davebshow commented on a diff in the pull request:

    https://github.com/apache/tinkerpop/pull/741#discussion_r150589566
  
    --- Diff: 
gremlin-python/src/main/jython/tests/structure/io/test_graphson.py ---
    @@ -121,6 +125,19 @@ class X(object):
             serdes.objectify.assert_called_once_with(value, reader)
             assert o is serdes.objectify()
     
    +    def test_datetime(self):
    +        dt = self.graphson_reader.readObject(json.dumps({"@type": 
"g:Date", "@value": 1481750076295}))
    +        assert isinstance(dt, datetime.datetime)
    --- End diff --
    
    Yeah I guess. TBH, I don't find any of these tests too meaningful, which is 
why I added the functional IO tests at the end that actually send and receive 
messages from the server and verify that they are equal. I can add the asserts 
though if you want.


---

Reply via email to