[ 
https://issues.apache.org/jira/browse/TINKERPOP-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16257038#comment-16257038
 ] 

ASF GitHub Bot commented on TINKERPOP-1784:
-------------------------------------------

Github user jorgebay commented on a diff in the pull request:

    https://github.com/apache/tinkerpop/pull/747#discussion_r151698077
  
    --- Diff: gremlin-test/features/sideEffect/Group.feature ---
    @@ -0,0 +1,244 @@
    +# Licensed to the Apache Software Foundation (ASF) under one
    +# or more contributor license agreements.  See the NOTICE file
    +# distributed with this work for additional information
    +# regarding copyright ownership.  The ASF licenses this file
    +# to you under the Apache License, Version 2.0 (the
    +# "License"); you may not use this file except in compliance
    +# with the License.  You may obtain a copy of the License at
    +#
    +# http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing,
    +# software distributed under the License is distributed on an
    +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +# KIND, either express or implied.  See the License for the
    +# specific language governing permissions and limitations
    +# under the License.
    +
    +Feature: Step - group()
    +
    +  Scenario: g_V_group_byXnameX
    +    Given the modern graph
    +    And the traversal of
    +      """
    +      g.V().group().by("name")
    +      """
    +    When iterated to list
    +    Then the result should be unordered
    +      | result |
    +      | m[{"ripple":"l[v[ripple]]", "peter":"l[v[peter]]", 
"vadas":"l[v[vadas]]", "josh": "l[v[josh]]", "lop":"l[v[lop]]", 
"marko":"l[v[marko]]"}] |
    +
    +  Scenario: g_V_group_byXnameX_by
    +    Given the modern graph
    +    And the traversal of
    +      """
    +      g.V().group().by("name").by()
    +      """
    +    When iterated to list
    +    Then the result should be unordered
    +      | result |
    +      | m[{"ripple":"l[v[ripple]]", "peter":"l[v[peter]]", 
"vadas":"l[v[vadas]]", "josh": "l[v[josh]]", "lop":"l[v[lop]]", 
"marko":"l[v[marko]]"}] |
    +
    +  Scenario: g_V_groupXaX_byXnameX_capXaX
    +    Given the modern graph
    +    And the traversal of
    +      """
    +      g.V().group("a").by("name").cap("a")
    +      """
    +    When iterated to list
    +    Then the result should be unordered
    +      | result |
    +      | m[{"ripple":"l[v[ripple]]", "peter":"l[v[peter]]", 
"vadas":"l[v[vadas]]", "josh": "l[v[josh]]", "lop":"l[v[lop]]", 
"marko":"l[v[marko]]"}] |
    +
    +  Scenario: g_V_hasXlangX_groupXaX_byXlangX_byXnameX_out_capXaX
    +    Given the modern graph
    +    And the traversal of
    +      """
    +      g.V().has("lang").group("a").by("lang").by("name").out().cap("a")
    +      """
    +    When iterated to list
    +    Then the result should be unordered
    +      | result |
    +      | m[{"java":["lop","ripple"]}] |
    +
    +  Scenario: g_V_hasXlangX_group_byXlangX_byXcountX
    +    Given the modern graph
    +    And the traversal of
    +      """
    +      g.V().has("lang").group().by("lang").by(__.count())
    +      """
    +    When iterated to list
    +    Then the result should be unordered
    +      | result |
    +      | m[{"java":"d[2].l"}] |
    +
    +  Scenario: g_V_repeatXout_groupXaX_byXnameX_byXcountX_timesX2X_capXaX
    +    Given the modern graph
    +    And the traversal of
    +      """
    +      
g.V().repeat(__.out().group("a").by("name").by(__.count())).times(2).cap("a")
    +      """
    +    When iterated to list
    +    Then the result should be unordered
    +      | result |
    +      | m[{"ripple":"d[2].l", "vadas":"d[1].l", "josh":"d[1].l", 
"lop":"d[4].l"}] |
    +
    +  Scenario: g_V_group_byXoutE_countX_byXnameX
    +    Given an unsupported test
    +    Then nothing should happen because
    +      """
    +      The result returned is not supported under GraphSON 2.x and 
therefore cannot be properly asserted. More
    +      specifically it has numeric keys which basically get toString()'d 
under GraphSON 2.x. This test can be supported
    +      with GraphSON 3.x.
    +      """
    +
    +  Scenario: g_V_groupXaX_byXlabelX_byXoutE_weight_sumX_capXaX
    +    Given the modern graph
    +    And the traversal of
    +      """
    +      
g.V().group("a").by(T.label).by(__.outE().values("weight").sum()).cap("a")
    +      """
    +    When iterated to list
    +    Then the result should be unordered
    +      | result |
    +      | m[{"software":"d[0].i", "person":"d[3.5].d}] |
    --- End diff --
    
    Typo `"d[3.5].d"`


> Gremlin Language Test Suite
> ---------------------------
>
>                 Key: TINKERPOP-1784
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1784
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: test-suite
>    Affects Versions: 3.2.6
>            Reporter: stephen mallette
>            Assignee: stephen mallette
>
> Provide for a more language agnostic test framework for the Gremlin Language 
> so that we can properly test GLVs. The current test suite is completely tied 
> to the JVM.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to