GitHub user pietermartin opened a pull request:

    https://github.com/apache/tinkerpop/pull/756

    TINKERPOP-1832: TraversalHelper.replaceStep sets previousStep to the wrong 
step

    `TraversalHelper.replaceStep` needs to first remove the step before adding 
in the new step. Else it gets its `previousStep` pointer wrong.
        
    Added `TraversalHelperTest.shouldSetPreviousStepToEmptyStep` which was the 
scenario that originally made me aware of the issue.
        
    Ran `mvn clean install` and tested Sqlg's tests with the fix.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pietermartin/tinkerpop TINKERPOP-1832

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/756.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #756
    
----
commit 8bc4b36f52d12e37b7d8f37f7d2240caa233106f
Author: pieter <pieter.mar...@riseup.net>
Date:   2017-11-22T08:56:43Z

    TINKERPOP-1832 - Fix bug where TraversalHelper.replaceStep sets the steps' 
previousStep incorrectly.
    It needs to remove the replaced step before inserting the new step.

----


---

Reply via email to