[
https://issues.apache.org/jira/browse/TINKERPOP-1844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311591#comment-16311591
]
ASF GitHub Bot commented on TINKERPOP-1844:
-------------------------------------------
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/769
TINKERPOP-1844 Default GraphSON 3.0 for GLV tests in gremlin-python
https://issues.apache.org/jira/browse/TINKERPOP-1844
This is a breaking change because `g:Set` no longer returns a `Set` in
python. It is coerced to `List` to account for numeric equality semantics of
Java vs Python.
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1844
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/769.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #769
----
commit 102c9b4300fae2f755c998ee1ed6ef101f85478c
Author: Stephen Mallette <spmva@...>
Date: 2018-01-04T14:26:57Z
TINKERPOP-1844 Default GraphSON 3.0 for GLV tests in gremlin-python
This is a breaking change because g:Set no longer returns a Set in python.
It is coerced to List to account for numeric equality semantics of Java vs
Python.
----
> Python GLV test should run for GraphSON 3.0
> -------------------------------------------
>
> Key: TINKERPOP-1844
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1844
> Project: TinkerPop
> Issue Type: Improvement
> Components: python
> Affects Versions: 3.3.0
> Reporter: stephen mallette
> Priority: Critical
> Labels: breaking
>
> The GLV tests are running for python on GraphSON 2.0. When I ran them for
> GraphSON 3.0 I received some strange errors that looked like they might have
> been related to bulking, but I can't say for sure. Anyway, we should
> definitely be running these tests against 3.0 and potentially 2.0 as well
> (2.0 can be a separate ticket and is less of a priority).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
