Eugene Chung created TINKERPOP-1863:
---------------------------------------

             Summary: Delaying the setting of requestId till the RequestMessage 
instantiation time
                 Key: TINKERPOP-1863
                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1863
             Project: TinkerPop
          Issue Type: Improvement
          Components: driver
            Reporter: Eugene Chung
            Priority: Minor


The Builder class of org.apache.tinkerpop.gremlin.driver.message.RequestMessage 
class sets its requestId field as UUID.randomUUID() by default.

But I think it should be fixed not to be set by default. The reasons are below;

- UUID.randomUUID() uses SecureRandom which grabs the lock at JVM level,
which means whole threads calling this API compete against each other.
- Getting random value from SecureRandom is somewhat CPU-intensive job.
- If a gremlin client sends requestId by itself, the costs above are useless.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to