[
https://issues.apache.org/jira/browse/TINKERPOP-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16318324#comment-16318324
]
ASF GitHub Bot commented on TINKERPOP-1860:
-------------------------------------------
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/773
TINKERPOP-1860 Added tests for valueMap(true) variations
https://issues.apache.org/jira/browse/TINKERPOP-1860
Somewhat surprised we didn't have tests for this variation of `valueMap()`.
All tests pass with `docker/build.sh -t -n -i`
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1860
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/773.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #773
----
commit caede9c8ca5cad07b947a53b38a9cc145500f6bf
Author: Stephen Mallette <spmva@...>
Date: 2017-12-29T13:02:55Z
TINKERPOP-1860 Added tests for valueMap(true) variations
Note that with GraphSON 2.0 we get back string representations of T.id and
T.label. That may change for GraphSON 3.0 on the 3.3.x line of code.
----
> valueMap(True) result in error in gremlin-python
> ------------------------------------------------
>
> Key: TINKERPOP-1860
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1860
> Project: TinkerPop
> Issue Type: Bug
> Components: python
> Affects Versions: 3.3.0
> Environment: Windows 10
> jvm 1.8, python 3.5
> tinkerpop 3.3.0
> Reporter: yokota masanori
> Priority: Minor
>
> I use [True] value as a argument of valueMap() step. And it result in error
> as below.
> (This error didn't occur in Groovy Query and return list of Value Map with id
> and label)
> // Python
> graph = Graph()
> g =
> graph.traversal().withRemote(DriverRemoteConnection('ws://localhost:8182/gremlin','g'))
> g.V().valueMap(True).toList()
> =>
> TypeError
> ----> 1 g.V().valueMap(True).toList()
> ...
> ~\site-packages\gremlin_python\structure\io\graphsonV3d0.py in
> objectify(cls, l, reader)
> 453 x = 0
> 454 while x < len(l):
> --> 455 new_dict[reader.toObject(l[x])] = reader.toObject(l[x
> + 1])
> 456 x = x + 2
> 457 return new_dict
> TypeError: unhashable type: 'dict'
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
