[ 
https://issues.apache.org/jira/browse/TINKERPOP-1867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16319538#comment-16319538
 ] 

ASF GitHub Bot commented on TINKERPOP-1867:
-------------------------------------------

GitHub user dkuppitz opened a pull request:

    https://github.com/apache/tinkerpop/pull/775

    TINKERPOP-1867 union() can produce extra traversers 

    https://issues.apache.org/jira/browse/TINKERPOP-1867
    
    Implemented `reset()` in `ComputerAwareStep` to reset the 
`previousIterator`, and reset the `finalStep` in `DefaultTraversal`.
    
    This fixes the false behavior, mainly seen in reducing barrier steps.
    
    ```
    $ docker/build.sh -t -i
    ...
    [INFO] 
------------------------------------------------------------------------
    [INFO] Reactor Summary:
    [INFO] 
    [INFO] Apache TinkerPop .................................. SUCCESS 
[1:45.623s]
    [INFO] Apache TinkerPop :: Gremlin Shaded ................ SUCCESS [21.575s]
    [INFO] Apache TinkerPop :: Gremlin Core .................. SUCCESS [57.690s]
    [INFO] Apache TinkerPop :: Gremlin Test .................. SUCCESS [6.146s]
    [INFO] Apache TinkerPop :: Gremlin Groovy ................ SUCCESS 
[3:03.207s]
    [INFO] Apache TinkerPop :: Gremlin Groovy Test ........... SUCCESS [4.203s]
    [INFO] Apache TinkerPop :: TinkerGraph Gremlin ........... SUCCESS 
[2:59.389s]
    [INFO] Apache TinkerPop :: Gremlin Benchmark ............. SUCCESS [7.549s]
    [INFO] Apache TinkerPop :: Gremlin Driver ................ SUCCESS 
[1:31.627s]
    [INFO] Apache TinkerPop :: Neo4j Gremlin ................. SUCCESS [0.936s]
    [INFO] Apache TinkerPop :: Gremlin Server ................ SUCCESS 
[15:29.995s]
    [INFO] Apache TinkerPop :: Gremlin Python ................ SUCCESS 
[2:40.883s]
    [INFO] Apache TinkerPop :: Gremlin.Net ................... SUCCESS [2.247s]
    [INFO] Apache TinkerPop :: Gremlin.Net - Source .......... SUCCESS [44.422s]
    [INFO] Apache TinkerPop :: Gremlin.Net - Tests ........... SUCCESS [44.304s]
    [INFO] Apache TinkerPop :: Hadoop Gremlin ................ SUCCESS 
[6:30.134s]
    [INFO] Apache TinkerPop :: Spark Gremlin ................. SUCCESS 
[15:04.061s]
    [INFO] Apache TinkerPop :: Giraph Gremlin ................ SUCCESS 
[2:23:46.498s]
    [INFO] Apache TinkerPop :: Gremlin Console ............... SUCCESS 
[4:00.598s]
    [INFO] Apache TinkerPop :: Gremlin Archetype ............. SUCCESS [0.080s]
    [INFO] Apache TinkerPop :: Archetype - TinkerGraph ....... SUCCESS [33.522s]
    [INFO] Apache TinkerPop :: Archetype - Server ............ SUCCESS [15.100s]
    [INFO] Apache TinkerPop :: Archetype - DSL ............... SUCCESS [3.588s]
    [INFO] 
------------------------------------------------------------------------
    [INFO] BUILD SUCCESS
    [INFO] 
------------------------------------------------------------------------
    [INFO] Total time: 3:21:02.647s
    [INFO] Finished at: Wed Jan 10 01:21:22 UTC 2018
    [INFO] Final Memory: 173M/631M
    [INFO] 
------------------------------------------------------------------------
    ```
    
    VOTE: +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1867

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/775.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #775
    
----
commit 2d4a4f8c19bd92625e414f41c6ceafc70862da87
Author: Daniel Kuppitz <daniel_kuppitz@...>
Date:   2018-01-10T01:40:48Z

    Implemented `reset()` in `ComputerAwareStep` to reset the 
`previousIterator` and reset the `finalStep` in `DefaultTraversal`.
    This fixes TINKERPOP-1867, a falsy behavior, mainly seen in reducing 
barrier steps.

----


> union() can produce extra traversers 
> -------------------------------------
>
>                 Key: TINKERPOP-1867
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1867
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: process
>    Affects Versions: 3.2.7
>            Reporter: stephen mallette
>            Assignee: stephen mallette
>
> Hard to say where this bug is coming from but basically the most simple 
> representation is:
> {code}
> gremlin> g.V(1,2).local(__.union(__.constant(1).count()))
> ==>1
> ==>0
> ==>1
> {code}
> Similar problems occur with {{sum()}} and other reducing barriers when used 
> in this context.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to