[
https://issues.apache.org/jira/browse/TINKERPOP-1858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321518#comment-16321518
]
ASF GitHub Bot commented on TINKERPOP-1858:
-------------------------------------------
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/767#discussion_r160843990
--- Diff:
gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/channel/HttpChannelizerIntegrateTest.java
---
@@ -18,15 +18,40 @@
*/
package org.apache.tinkerpop.gremlin.server.channel;
-
+import org.apache.http.NoHttpResponseException;
import org.apache.tinkerpop.gremlin.server.auth.SimpleAuthenticator;
import org.apache.tinkerpop.gremlin.server.Settings;
+import org.junit.Test;
+
import java.util.Map;
import java.util.HashMap;
+import java.net.SocketException;
public class HttpChannelizerIntegrateTest extends
AbstractGremlinServerChannelizerIntegrateTest {
+ @Override
+ public Settings overrideSettings(final Settings settings) {
+ super.overrideSettings(settings);
+ final String nameOfTest = name.getMethodName();
+ if (nameOfTest.equals("shouldBreakOnInvalidAuthenticationHandler")
) {
+ settings.authentication = getAuthSettings();
+ settings.authentication.authenticationHandler = "Foo.class";
+ }
+ return settings;
+ }
+
+ @Test
+ public void shouldBreakOnInvalidAuthenticationHandler() throws
Exception {
+ final CombinedTestClient client = new
CombinedTestClient(getProtocol());
+ try {
+ client.sendAndAssert("2+2", 4);
--- End diff --
this line should be followed by:
```java
fail("Should throw exception");
```
like we don't expect that `sendAndAssert` to actually work, right?
> HttpChannelizer regression: Does not create specified AuthenticationHandler
> ---------------------------------------------------------------------------
>
> Key: TINKERPOP-1858
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1858
> Project: TinkerPop
> Issue Type: Bug
> Components: server
> Affects Versions: 3.3.0
> Environment: All
> Reporter: Keith Lohnes
> Labels: easyfix, regression
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> HttpChannelizer creates a HttpBasicAuthenticationHandler instead of
> instantiating the specified AuthenticationHandler from the configuration
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
