[
https://issues.apache.org/jira/browse/TINKERPOP-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327465#comment-16327465
]
ASF GitHub Bot commented on TINKERPOP-1870:
-------------------------------------------
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/778#discussion_r161835490
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/gryo/GryoVersion.java
---
@@ -305,6 +307,7 @@ public String getVersion() {
add(GryoTypeReg.of(RangeGlobalStep.RangeBiOperator.class,
114));
add(GryoTypeReg.of(OrderGlobalStep.OrderBiOperator.class, 118,
new JavaSerializer()));
add(GryoTypeReg.of(ProfileStep.ProfileBiOperator.class, 119));
+ add(GryoTypeReg.of(VertexTraverserSet.class, 173));
--- End diff --
please move the "last id" comment down from:
https://github.com/apache/tinkerpop/pull/778/files#diff-f1eb3822f6d5659dd2bdc913ae475241R208
you might need to create a separate PR against master for us to review
because of this change because Gryo 3.0 will need a similar entry on master (i
suspect the kryo id will be different) and we'd need to be sure this all works
on master as well.
> n^2 synchronious operation in OLAP WorkerExecutor.execute() method
> ------------------------------------------------------------------
>
> Key: TINKERPOP-1870
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1870
> Project: TinkerPop
> Issue Type: Improvement
> Affects Versions: 3.2.7, 3.3.1
> Reporter: Artem Aliev
> Priority: Major
> Attachments: findTraverser1.png, findTraverser2.png,
> findTraverserFixed.png
>
>
> [https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/computer/traversal/WorkerExecutor.java#L80-L93]
> This block of code iterates over all remote traverses to select one related
> to the current vertex and remove it. This operation is repeated for the next
> vertex and so one. For following example query it means n^2 operations (n is
> number of vertices). All of them in sync block. multi core spark executor
> will do this operations serial.
> {code}
> g.V().emit().repeat(both().dedup()).count().next()
> {code}
> See jvisualvm screenshot.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
