[
https://issues.apache.org/jira/browse/TINKERPOP-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337460#comment-16337460
]
ASF GitHub Bot commented on TINKERPOP-1861:
-------------------------------------------
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/772
Sorry - you really shouldnt have any commits from our repo in this PR - it
should be all your work. The problem is that if when we look at the diff to
review, it contains changes that don't pertain to your work, which makes the
changes impossible to evaluate by themselves. I imagine you must have merged
tp32 into the branch in your fork or something. You should have instead
rebased your local changes onto our tp32 which would have re-wrote all of your
commits on top of ours so that the git history made it look like you had all
your changes on the head of tp32. Hope that makes sense. If you need some more
git explanation, please let me know.
> VertexProgram create with varargs for Graphs
> --------------------------------------------
>
> Key: TINKERPOP-1861
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1861
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.2.7
> Reporter: Philip Graff
> Priority: Minor
>
> VertexProgram.Builder.create(Graph) can be modified to
> VertexProgram.Builder.create(Graph...) so that passing in zero or many graphs
> is naturally handled. The current state of passing in null when no graph is
> needed is bad practice.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
