[ 
https://issues.apache.org/jira/browse/TINKERPOP-878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stephen mallette closed TINKERPOP-878.
--------------------------------------
    Resolution: Won't Do

On review, I don't think this is worth doing. To re-execute the whole suite of 
gremlin server tests to  validate what amounts to just a few lines of code 
(difference between websocket and nio) doesn't seem sensible. We have tests for 
nio and it exercises those few lines so that should be enough.

> Refactor Gremlin Server integration tests to be Client parameterized
> --------------------------------------------------------------------
>
>                 Key: TINKERPOP-878
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-878
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: server
>    Affects Versions: 3.0.2-incubating
>            Reporter: stephen mallette
>            Assignee: stephen mallette
>            Priority: Minor
>
> Would be nice if Gremlin Server integration tests (at least the ones that 
> make sense anyway) were executed over both Websockets and NIO to generally 
> validate their capabilities.  We could likely create parameterized tests to 
> do this.  That would also pave the way for easily testing new transports if 
> they are ever added.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to