stephen mallette commented on TINKERPOP-1505:

Based on the last comments here, I think I'm going to close this one out. We're 
going to have to think pretty hard about what transactions mean in TinkerPop 
4.x. I actually wonder if we'll do transactions at all to some degree. With 
more and more graph implementations become "server graphs" where one request 
equals one transaction, session-based communication continuing to die, bytecode 
and not scripts being the way of the future, and the possibility of growing 
GLVs into full-blown VMs, it seems like we might not need to focus too hard on 
trying to generalize transactions across graphs. 

> Transaction Status listener list gets overwritten
> -------------------------------------------------
>                 Key: TINKERPOP-1505
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1505
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: structure
>    Affects Versions: 3.1.4, 3.2.2
>            Reporter: Jason Plurad
>            Priority: Major
> Transaction status listener is not called when using Gremlin Server
> * Caused by the transaction listener list initialization in 
> [AbstractThreadLocalTransaction|https://github.com/apache/tinkerpop/blob/3.1.4/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/util/AbstractThreadLocalTransaction.java#L54-L59].
>   * There are 2 different threads in action during the Gremlin Server 
> initialization.
>     # The Groovy startup script evaluation which adds the listener
>     # The server itself handles the transaction commit or rollback. Both 
> threads end up calling on the {{ThreadLocal initialValue()}} which returns 
> {{new ArrayList()}} and effectively wipes out the listener.
>     * Fix is to initialize the list once.
> {noformat}
>     protected final ThreadLocal<List<Consumer<Transaction.Status>>> 
> transactionListeners = new ThreadLocal<List<Consumer<Transaction.Status>>>() {
>         private List<Consumer<Transaction.Status>> list = new ArrayList<>();
>         @Override
>         protected List<Consumer<Transaction.Status>> initialValue() {
>             return list;
>         }
>     };
> {noformat}

This message was sent by Atlassian JIRA

Reply via email to