[ 
https://issues.apache.org/jira/browse/TINKERPOP-1857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364759#comment-16364759
 ] 

ASF GitHub Bot commented on TINKERPOP-1857:
-------------------------------------------

GitHub user spmallette opened a pull request:

    https://github.com/apache/tinkerpop/pull/798

    TINKERPOP-1857 - Consistency in GLV tests

    https://issues.apache.org/jira/browse/TINKERPOP-1857
    
    This PR largely brings the GLV test suite into consistency with the java 
test suite. It enables a check that i've long had that will fail the build if 
someone adds a new test to the java test suite but not to the GLV suite so 
things should stay in sync going forward. 
    
    That said, this body of work isn't quite perfect in that:
    
    1. There's some failing tests for .NET and JS for which separate JIRA 
issues have been opened (or will be opened)- it's a small handful of may 30 
tests total out of hundreds.
    2. There were a bunch of tests that didn't translate well to the GLV suite 
- i had to "ignore" those for now. New issues will be created once the issues 
can be classified properly.
    
    Even with those detractors, this remains a pretty large body of work that 
validates a far greater percentage of our GLV code than before so I think it's 
ready to be merged as it stands.
    
    All tests pass with `docker/build.sh -t -i`
    
    VOTE +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1857

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/798.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #798
    
----
commit 1425f2948d5f54960ecf27dfacd6c020b7adcf72
Author: Stephen Mallette <spmva@...>
Date:   2017-12-27T18:18:15Z

    TINKERPOP-1857 General test naming fixes and other inconsistencies

commit a1d040329e1da734f1af46513e36fd941f3e15b0
Author: Stephen Mallette <spmva@...>
Date:   2017-12-28T16:18:38Z

    TINKERPOP-1857 Improved handling of empty graph in python glv tests
    
    Caches were hardcoded to the modern graph. For empty graph this caused 
hassles because the cache couldn't be initialized until after the graph 
initializer step was executed. Still a bit messy due to cut/paste issues. Need 
to clean that up at a later point.

commit e96a2a60e2038d2049215c33a83a8623a9e399c6
Author: Stephen Mallette <spmva@...>
Date:   2017-12-28T16:25:06Z

    TINKERPOP-1857 Python GLV tests were not string-ing IDs

commit c06e8a26be0bcf9a9749a6f812a13f5840deb25c
Author: Stephen Mallette <spmva@...>
Date:   2017-12-28T20:00:54Z

    TINKERPOP-1857 Generation of P for python was incorrect
    
    The template was generating not() bytecode with the python naming of 
not_(). There were also duplicate functions in the template that needed to be 
removed.

commit 1f2530e84c1b75e9ab8df775835be9b4afc59a35
Author: Stephen Mallette <spmva@...>
Date:   2017-12-28T20:03:22Z

    TINKERPOP-1857 Added ignore for a has() test in the python GLV tests
    
    Created TINKERPOP-1859 regarding bad bytecode generation for complex P 
instances

commit e74747d35861ff8a2a5c2c5fc6003de01179d7ad
Author: Stephen Mallette <spmva@...>
Date:   2017-12-28T20:05:07Z

    TINKERPOP-1857 Added more has() tests to the GLV suite.
    
    Fixed some consistency problems in the java test itself.

commit 20b10c445b84fc775487d8b288208a4b7b8df252
Author: Stephen Mallette <spmva@...>
Date:   2017-12-28T21:42:30Z

    TINKERPOP-1857 Added support for empty lists and sets in python GLV test 
runner

commit b2c79d61c019223a94ac890980955c3b819c4bc1
Author: Stephen Mallette <spmva@...>
Date:   2017-12-28T23:38:24Z

    TINKERPOP-1857 Full has() test suite for GLVs
    
    FeatureCoverageTest now passes for it. Added more consistency to the java 
test.

commit c4fd3e13f48c5c0dec5d0827fea8f4af61b44a31
Author: Stephen Mallette <spmva@...>
Date:   2018-01-24T13:08:10Z

    TINKERPOP-1857 Got range() GLV tests all in place

commit 68669ea63f17fe517cfe5c3a049034e2de8062bb
Author: Stephen Mallette <spmva@...>
Date:   2018-01-24T14:53:27Z

    TINKERPOP-1857 Rebased and added new union() test

commit d556f77994712c3fb91ab09e08720ced273b4474
Author: Stephen Mallette <spmva@...>
Date:   2018-01-24T15:27:13Z

    TINKERPOP-1857 Fixed up union() and range() tests that were failing

commit 784c3d10dbe40a4acf7cac93abba03977631acb1
Author: Stephen Mallette <spmva@...>
Date:   2018-01-24T17:14:01Z

    TINKERPOP-1857 Added where() GLV test

commit 7a445844c2cdb0aede731e2d88a592dafebcf9e6
Author: Stephen Mallette <spmva@...>
Date:   2018-02-01T15:28:35Z

    TINKERPOP-1857 Included GLV tests for addV()

commit ade1daf8670de64c3f57d9c7f13c2645e58754ac
Author: Stephen Mallette <spmva@...>
Date:   2018-02-01T18:06:44Z

    TINKERPOP-1857 Added GLV match() tests

commit 2735643fb1811be3426900d2df64795430f9eedf
Author: Stephen Mallette <spmva@...>
Date:   2018-02-01T18:33:12Z

    TINKERPOP-1857 Added new GLV min() test that came in after rebase

commit 314481e5e7410cdd6812a5095f3db6e705ec7f81
Author: Stephen Mallette <spmva@...>
Date:   2018-02-06T13:04:10Z

    TINKERPOP-1857 Added full coverage of order() GLV tests

commit 43519778b0f0c71a93ff0d91efc153995e1ebec6
Author: Stephen Mallette <spmva@...>
Date:   2018-02-06T14:08:55Z

    TINKERPOP-1857 select() GLV tests

commit 5db5f2188137c8088f3433910cf48f6bb1e2eb6b
Author: Stephen Mallette <spmva@...>
Date:   2018-02-06T15:55:14Z

    TINKERPOP-1857 sack() inject() cap() GLV tests

commit 97d4511c65ecb410b566a13b594aaa2786afe2ec
Author: Stephen Mallette <spmva@...>
Date:   2018-02-07T13:19:26Z

    TINKERPOP-1857 Fixed a bad has() GLV test
    
    Made test naming more consistent.

commit bdd5e4c25c16dbea08f6127e9d12dffc3397f818
Author: Stephen Mallette <spmva@...>
Date:   2018-02-09T14:44:25Z

    TINKERPOP-1857 Removed duplicate test in select() GLV tests

commit 10f29cbe94424a03f1710695fcd396cbc0ae95ff
Author: Stephen Mallette <spmva@...>
Date:   2018-02-09T14:52:37Z

    TINKERPOP-1857 Temporarily ignore test failures with .net GLV tests

commit 1e38023c7ebfb3ae83578625d9d99f60798abdcc
Author: Jorge Bay Gondra <jorgebaygondra@...>
Date:   2018-02-14T15:11:13Z

    JavaScript GLV: handle responses without identifier and clear handler

commit 2af60402d49957c3bd28e515afb981b68c4baafa
Author: Jorge Bay Gondra <jorgebaygondra@...>
Date:   2018-02-14T15:18:24Z

    JavaScript GLV: include Barrier and Pop in test traversal context

commit 58d93820e654a2c81c85c13ea9134b7ea0d459f2
Author: Stephen Mallette <spmva@...>
Date:   2018-02-14T15:46:58Z

    TINKERPOP-1857 Ignored a few failing tests for purpose of this issue
    
    Will create a new issue specific to the JS GLV to resolve these ignored 
tests.

commit 7212253e6ff962232c906705c14fa95067fd11b9
Author: Stephen Mallette <spmva@...>
Date:   2018-02-14T16:17:15Z

    TINKERPOP-1857 Added the new "sink" test for GLVs
    
    This involved adding "sink" infrastructure to the test server configuration 
and including it in the gherkin setups for each GLV

----


> GLV test suite consistency and completeness
> -------------------------------------------
>
>                 Key: TINKERPOP-1857
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1857
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: test-suite
>    Affects Versions: 3.2.7
>            Reporter: stephen mallette
>            Assignee: stephen mallette
>            Priority: Major
>             Fix For: 3.2.8, 3.3.2
>
>
> While the GLV test suite was largely completed in 3.2.7/3.3.1 there were a 
> number of tests that weren't fully migrated and minor naming inconsistencies 
> that needed to be addressed. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to