[
https://issues.apache.org/jira/browse/TINKERPOP-1586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366913#comment-16366913
]
ASF GitHub Bot commented on TINKERPOP-1586:
-------------------------------------------
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/799
TINKERPOP-1586 Added checkAdjacentVertices option to SubgraphStrategy
https://issues.apache.org/jira/browse/TINKERPOP-1586
This change allows the user to turn off an aspect of `SubgraphStrategy`
that prevents it from working properly in OLAP situations. Added some better
javadoc to explain the settings for this strategy.
All tests pass with `docker/build.sh -t -n -i`
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1586
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/799.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #799
----
commit d1121544017acf1189f0270f60b5f1f402fec0ea
Author: Stephen Mallette <spmva@...>
Date: 2018-02-15T21:22:58Z
TINKERPOP-1586 Added checkAdjacentVertices option to SubgraphStrategy
This change allows the user to turn off an aspect of SubgraphStrategy that
prevents it from working properly in OLAP situations.
----
> SubgraphStrategy in OLAP
> ------------------------
>
> Key: TINKERPOP-1586
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1586
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.2.3
> Reporter: Daniel Kuppitz
> Assignee: stephen mallette
> Priority: Major
>
> If a vertex filter is provided in {{SubgraphStrategy}}, then it will turn any
> edge step in the traversal into something like:
> {noformat}
> ...outE().filter(inV().vertexFilterCondittion())
> {noformat}
> This breaks any OLAP traversal (leaving the star graph) and is not even the
> behavior that you would always want. We should have an option to disable the
> adjacent vertex checks. In code this would just mean to replace this
> {{else}}:
> https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/decoration/SubgraphStrategy.java#L92
> ...with {{else if (checkAdjacentVertices)}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
