[ 
https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376193#comment-16376193
 ] 

ASF GitHub Bot commented on TINKERPOP-1862:
-------------------------------------------

Github user PBGraff commented on the issue:

    https://github.com/apache/tinkerpop/pull/801
  
    @spmallette : I believe this is ready now if you can run the Docker test: 
`docker/build.sh -t -n -i`


> TinkerGraph VertexProgram message passing doesn't work properly when using 
> Direction.BOTH
> -----------------------------------------------------------------------------------------
>
>                 Key: TINKERPOP-1862
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1862
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: process, tinkergraph
>    Affects Versions: 3.2.7
>            Reporter: Philip Graff
>            Priority: Major
>
> I think the messages are being sent properly in TinkerMessenger, but when I 
> call messenger.receiveMessages(), the vertex is getting messages from the 
> outVertex of their edges regardless of the edge direction. This is due to 
> line 71 of TinkerMessenger (linked below) which calls 
> Edge.vertices(direction).next(), thus getting the first result out of the 
> Vertex iterator. For IN or OUT, this isn't a problem. But for BOTH, following 
> line 124 of TinkerEdge (linked below), the outVertex is always returned 
> first. TinkerMessenger needs to be modified to return the correct vertex (I 
> think it's the one that != this.vertex).
> https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerMessenger.java#L71
> https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerEdge.java#L124



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to