[ 
https://issues.apache.org/jira/browse/TINKERPOP-1777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16384158#comment-16384158
 ] 

ASF GitHub Bot commented on TINKERPOP-1777:
-------------------------------------------

GitHub user dkuppitz opened a pull request:

    https://github.com/apache/tinkerpop/pull/805

    TINKERPOP-1777 Gremlin .max step returns -2147483648 for empty result sets

    https://issues.apache.org/jira/browse/TINKERPOP-1777
    
    Fixed the behavior of `min()`, `max()`, `mean()` and `sum()`.
    If no input is given, these steps will now throw a `FastNoElementException`.
    
    Also adjusted existing test cases to be in line with the new behavior.
    
    `docker/build.sh -t -i` passed.
    
    VOTE: +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1777

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/805.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #805
    
----
commit 32014426f12478e13d73b3c1bdca8df6d79d08da
Author: Daniel Kuppitz <daniel_kuppitz@...>
Date:   2018-02-27T17:15:07Z

    Fixed the behavior of `min()`, `max()`, `mean()` and `sum()`.
    If no input is given, these steps will now throw a `FastNoElementException`.
    
    Also adjusted existing test cases to be in line with the new behavior.

commit 7149f8e8c1c255420b19748632ee4d928480f2e2
Author: Daniel Kuppitz <daniel_kuppitz@...>
Date:   2018-03-02T21:04:58Z

    Updated release docs

----


> Gremlin .max step returns -2147483648 for empty result sets
> -----------------------------------------------------------
>
>                 Key: TINKERPOP-1777
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1777
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: process
>    Affects Versions: 3.2.6
>            Reporter: Sebastian Estevez
>            Assignee: Daniel Kuppitz
>            Priority: Major
>              Labels: breaking
>
> To reproduce:
> {code}gremlin> g.V().values('test').max()
> ==>-2147483648{code}
> This should probably return an exeption, "cannot take max of nothing"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to