[
https://issues.apache.org/jira/browse/TINKERPOP-1914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16398444#comment-16398444
]
ASF GitHub Bot commented on TINKERPOP-1914:
-------------------------------------------
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/813
i think this is ok to add back. i obviously never factored out the
underlying ability to pass that service to the `ServerGremlinExecutor` so I
think it might be ok to allow it to be passed in on the `GremlinServer` class.
Currently, this PR is targeted at the master branch which means it is aimed at
not being available until 3.4.0. If you would like to see this change in the
3.3.2 release that will happen in a few weeks, then you should re-target to the
tp33 branch.
> Support construct a GremlinServer instance from gremlin executor service
> ------------------------------------------------------------------------
>
> Key: TINKERPOP-1914
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1914
> Project: TinkerPop
> Issue Type: Improvement
> Components: server
> Reporter: Jermy Li
> Priority: Major
>
> This constructor is useful when Gremlin Server is being used in an embedded
> style and there is a need to share thread pools with the hosting application.
> A constructor that can do this has been removed since:
> [https://github.com/apache/tinkerpop/commit/67cd592742cc84cefdb1368a374119e7d4290e1e#diff-38a2e38559996e996423c0ca2ff597fbL128],
> which results in incompatible with the existing code.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
