[ 
https://issues.apache.org/jira/browse/TINKERPOP-1930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413243#comment-16413243
 ] 

ASF GitHub Bot commented on TINKERPOP-1930:
-------------------------------------------

Github user dkuppitz commented on the issue:

    https://github.com/apache/tinkerpop/pull/825
  
    I think there's more that can be removed:
    
    ```diff
    diff --git a/pom.xml b/pom.xml
    index ef2be4821d..ddd9167a51 100644
    --- a/pom.xml
    +++ b/pom.xml
    @@ -582,15 +582,6 @@ limitations under the License.
                             <groupId>commons-logging</groupId>
                             <artifactId>commons-logging</artifactId>
                         </exclusion>
    -                    <!-- conflicts with giraph-core (which appears to have 
more consistent dependencies) -->
    -                    <exclusion>
    -                        <groupId>org.codehaus.jackson</groupId>
    -                        <artifactId>jackson-core-asl</artifactId>
    -                    </exclusion>
    -                    <exclusion>
    -                        <groupId>org.codehaus.jackson</groupId>
    -                        <artifactId>jackson-mapper-asl</artifactId>
    -                    </exclusion>
                         <!-- conflict with TinkerPop tests -->
                         <exclusion>
                             <groupId>junit</groupId>
    @@ -1146,7 +1137,7 @@ limitations under the License.
                                         
<overview>${basedir}/docs/javadoc/overview.html</overview>
                                         <quiet>true</quiet>
                                         <sourcepath>
    -                                        
giraph-gremlin/src/main/java:gremlin-core/src/main/java:gremlin-driver/src/main/java:gremlin-groovy/src/main/java:gremlin-python/src/main/java:gremlin-server/src/main/java:gremlin-test/src/main/java:hadoop-gremlin/src/main/java:neo4j-gremlin/src/main/java:spark-gremlin/src/main/java:tinkergraph-gremlin/src/main/java
    +                                        
gremlin-core/src/main/java:gremlin-driver/src/main/java:gremlin-groovy/src/main/java:gremlin-python/src/main/java:gremlin-server/src/main/java:gremlin-test/src/main/java:hadoop-gremlin/src/main/java:neo4j-gremlin/src/main/java:spark-gremlin/src/main/java:tinkergraph-gremlin/src/main/java
                                         </sourcepath>
                                     </configuration>
                                 </execution>
    ```
    
    However, `docker/build.sh -d` fails with an `AbstractMethodError` in Spark, 
but I'm afraid that's a problem in other branches as well.


> Drop support for Giraph
> -----------------------
>
>                 Key: TINKERPOP-1930
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1930
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: hadoop
>    Affects Versions: 3.3.1
>            Reporter: stephen mallette
>            Assignee: stephen mallette
>            Priority: Major
>              Labels: breaking
>             Fix For: 3.4.0
>
>
> Remove support for Giraph as per discussion on mailing list:
> https://lists.apache.org/thread.html/99b04ede4c165bfba1629e2df60c8837dde9e22cb220d15cd19e78ef@%3Cdev.tinkerpop.apache.org%3E



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to