Upon investigation, we do have tests in the general process suite that should have caught this, but "remote" tests fall into a scenario where tests with lambdas are quietly ignored. This happens because RemoteStrategy throws does a silent check during tests for lambdas and throws a VerificationException (i think computer strategies do this as well) which is then interpreted by the test rig as "untestable - ignore". I think this can be fixed for remoting if we can ever get those tests to run off the Gherkin test suite rather than gremlin-test. In the mean time, I think I will just add a test to just smoke test the Lambda class and commit that as part of:
https://issues.apache.org/jira/browse/TINKERPOP-1953 On Mon, Apr 23, 2018 at 8:35 AM, Stephen Mallette <[email protected]> wrote: > We have tests that do lambdas, but I guess they don't specifically cover > use of the Lambda class in this way. Damn........ > > On Mon, Apr 23, 2018 at 8:31 AM, Robert Dale <[email protected]> wrote: > >> Do we not have any lambda tests that would catch this? >> >> Robert Dale >> >> On Mon, Apr 23, 2018 at 8:29 AM, Robert Dale <[email protected]> wrote: >> >> > https://issues.apache.org/jira/browse/GROOVY-8494 >> > >> > Robert Dale >> > >> > On Mon, Apr 23, 2018 at 8:21 AM, Stephen Mallette <[email protected] >> > >> > wrote: >> > >> >> I feel like I ran into this error last week: >> >> >> >> gremlin> org.apache.tinkerpop.gremlin.util.function.Lambda.function("{ >> >> it.get() }") >> >> (class: org/apache/tinkerpop/gremlin/util/function/Lambda$function$0, >> >> method: callStatic signature: >> >> (Ljava/lang/Class;[Ljava/lang/Object;)Ljava/lang/Object;) Illegal >> type in >> >> constant pool >> >> Type ':help' or ':h' for help. >> >> Display stack trace? [yN])) >> >> >> >> and then it went away somehow and now it's back. Happening in >> >> 3.2.9-SNAPSHOT and seeing it now in the released 3.3.2 console as well. >> >> I'm guessing it's a bug in groovy that we picked up when we upgraded. >> It >> >> seems to be a problem that exists across all script processing so even >> >> Gremlin Server fails to construct the lambda. >> >> >> >> I bumped to Groovy 2.4.15 and it goes away :/ oddly i'm not seeing >> >> anything in the 2.4.15 release notes that addresses this issue. >> >> >> >> This is a really bad bug because it means that users can't construct >> >> lambdas for remoting purposes. Can someone else please confirm that >> they >> >> see this problem as well and that it's not just me? >> >> >> > >> > >> > >
