[ 
https://issues.apache.org/jira/browse/TINKERPOP-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448126#comment-16448126
 ] 

ASF GitHub Bot commented on TINKERPOP-1944:
-------------------------------------------

GitHub user jorgebay opened a pull request:

    https://github.com/apache/tinkerpop/pull/852

    TINKERPOP-1944 Export DriverRemoteConnection

    Export `DriverRemoteConnection`.
    
    https://issues.apache.org/jira/browse/TINKERPOP-1944
    
    VOTE +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1944

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/852.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #852
    
----
commit d037ef7049f36410caba9362bd60cb8dfc04f857
Author: Jorge Bay Gondra <jorgebaygondra@...>
Date:   2018-04-23T13:13:32Z

    TINKERPOP-1944 Export DriverRemoteConnection

----


> JavaScript GLV: DriverRemoteConnection is not exported in the root module
> -------------------------------------------------------------------------
>
>                 Key: TINKERPOP-1944
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1944
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: javascript
>    Affects Versions: 3.2.8, 3.3.2
>            Reporter: Jorge Bay
>            Priority: Major
>             Fix For: 3.2.9, 3.3.3
>
>
> {{DriverRemoteConnection}} should be exported inside the driver module.
> Users can still access the {{DriverRemoteConnection}} class using the path:
> {code:javascript}
> const DriverRemoteConnection = 
> require('./node_modules/gremlin/lib/driver/driver-remote-connection.js');
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to