[
https://issues.apache.org/jira/browse/TINKERPOP-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448616#comment-16448616
]
ASF GitHub Bot commented on TINKERPOP-1628:
-------------------------------------------
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/844#discussion_r183488493
--- Diff: gremlin-test/features/map/Select.feature ---
@@ -514,4 +514,20 @@ Feature: Step - select()
Then the result should be unordered
| result |
| d[2].l |
- | d[2].l |
\ No newline at end of file
+ | d[2].l |
+
+ Scenario:
g_V_asXaX_groupXmX_by_byXbothE_countX_barrier_selectXmX_selectXselectXaXX
+ Given the modern graph
+ And the traversal of
+ """
+
g.V().as("a").group("m").by().by(__.bothE().count()).barrier().select("m").select(__.select("a"))
+ """
+ When iterated to list
+ Then the result should be unordered
+ | result |
+ | d[3].l |
+ | d[1].l |
+ | d[3].l |
+ | d[3].l |
+ | d[1].l |
+ | d[1].l |
--- End diff --
Could you please add one more test to include the other method you added -
`select(Pop,Traversal)` ? I think it's worth exercising all these top level
steps on the odd chance that something stops working somewhere.
> Implement TraversalSelectStep
> -----------------------------
>
> Key: TINKERPOP-1628
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1628
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.3.0
> Reporter: Daniel Kuppitz
> Assignee: Daniel Kuppitz
> Priority: Major
>
> It should be possible to have nested {{select()}} or rather to select dynamic
> keys.
> {noformat}
> gremlin> aliases = ["marko":"okram"]
> gremlin> g.withSideEffect("a", aliases).V().hasLabel("person").
> values("name").as("n").
> optional(select("a").select(select("n")))
> ==>okram
> ==>vadas
> ==>josh
> ==>peter
> {noformat}
> I know there are more steps that could / should allow traversals, but to me
> {{select()}} seems to be the most important one (perhaps because the
> workaround is / can be super expensive).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
