[GitHub] tinkerpop pull request #855: TINKERPOP-1950 Cached global strategy lookups d...

[jorgebay]

Github user jorgebay commented on a diff in the pull request:

    https://github.com/apache/tinkerpop/pull/855#discussion_r183959745
  
    --- Diff: 
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/TraversalStrategies.java
 ---
    @@ -63,6 +63,8 @@
      */
     public interface TraversalStrategies extends Serializable, Cloneable {
     
    +    static Set<Class> LOADED = new HashSet<>();
    --- End diff --
    
    Shouldn't we use a collection that supports concurrent modification? 
Different threads might be adding items to the collection.
    
    Also, we could move the declaration to `GlobalCache`?.


---