[ 
https://issues.apache.org/jira/browse/TINKERPOP-1869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452050#comment-16452050
 ] 

ASF GitHub Bot commented on TINKERPOP-1869:
-------------------------------------------

GitHub user spmallette opened a pull request:

    https://github.com/apache/tinkerpop/pull/857

    TINKERPOP-1869 Allowed iterate() after profile()

    https://issues.apache.org/jira/browse/TINKERPOP-1869
    
    The `iterate()` method adds a `NoneStep` that was preventing traversals 
like `g.V().profile().iterate()`. Not the typical type of traversal you would 
do, but it seems like it should be allowed for consistency sake.
    
    All tests pass with `docker/build.sh -t -i`
    
    VOTE +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1869

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/857.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #857
    
----
commit 374b51a3fcb58ee6a7601b32d80ccd1e7a680f6a
Author: Stephen Mallette <spmva@...>
Date:   2018-04-24T23:07:28Z

    TINKERPOP-1869 Allowed iterate() after profile()
    
    The iterate() method adds a NoneStep that was preventing traversals like 
g.V().profile().iterate(). Not the typical type of traversal you would do, but 
it seems like it should be allowed for consistency sake.

----


> Profile step and iterate do not play nicely with each other
> -----------------------------------------------------------
>
>                 Key: TINKERPOP-1869
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1869
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: process
>    Affects Versions: 3.3.1
>            Reporter: Bryn Cooke
>            Assignee: stephen mallette
>            Priority: Minor
>
> Profile step doesn't like it if there are any other steps after it. However 
> if someone calls profile().iterate() they will get an error as iterate 
> appends a NoneStep to the end of the traversal.
> Even though this means that the results of the profile would never be 
> returned I think that profile step should allow None step to follow it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to