[ 
https://issues.apache.org/jira/browse/TINKERPOP-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452223#comment-16452223
 ] 

ASF GitHub Bot commented on TINKERPOP-1943:
-------------------------------------------

Github user jorgebay commented on a diff in the pull request:

    https://github.com/apache/tinkerpop/pull/858#discussion_r184052492
  
    --- Diff: 
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/driver/driver-remote-connection.js
 ---
    @@ -33,7 +33,7 @@ const responseStatusCode = {
       noContent: 204,
       partialContent: 206
     };
    -const defaultMimeType = 'application/vnd.gremlin-v2.0+json';
    +const defaultMimeType = 'application/vnd.gremlin-v3.0+json';
    --- End diff --
    
    The user can configure to use GraphSON2 by setting the mime type when 
creating the `DriverRemoteConnection` instance:
    
    ```javascript
    const connection = new DriverRemoteConnection({ mimeType: 
'application/vnd.gremlin-v2.0+json' });
    ```
    
    I think in any case, is highly unlikely a user would like to use a previous 
version of the serialization format with the newer version.
    
    It now defaults to GraphSON3 and all tests run using GraphSON3. I haven't 
changed the scripts to make a GraphSON2 and GraphSON3 run as one is a superset 
of the other.


> JavaScript GLV: Support GraphSON3
> ---------------------------------
>
>                 Key: TINKERPOP-1943
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1943
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: javascript
>    Affects Versions: 3.3.2
>            Reporter: Jorge Bay
>            Priority: Major
>
> Default GraphSON version for gremlin-javascript is GraphSON2 and newer 
> version is not supported, which can be a pain for users getting started with 
> the GLV in 3.3+.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to