[ 
https://issues.apache.org/jira/browse/TINKERPOP-1956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16456958#comment-16456958
 ] 

ASF GitHub Bot commented on TINKERPOP-1956:
-------------------------------------------

GitHub user spmallette opened a pull request:

    https://github.com/apache/tinkerpop/pull/861

    TINKERPOP-1956 Deprecated Order.incr and Order.decr

    https://issues.apache.org/jira/browse/TINKERPOP-1595
    
    Replaced by `Order.asc` and `Order.desc` respectively. Left a number of 
uses of `decr`/`incr` so as to ensure ongoing compatibility during deprecation.
    
    Feel free to VOTE, but this won't merge until after we open 3.3.4 for 
development.
    
    All tests pass with `docker/build.sh -t -n -i`
    
    VOTE +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1956

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/861.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #861
    
----
commit a937287d983c179668af92696f6e43e2151568bf
Author: Stephen Mallette <spmva@...>
Date:   2018-04-27T10:22:13Z

    TINKERPOP-1956 Deprecated Order.incr and Order.decr
    
    Replaced by Order.asc and Order.desc respectively. Left a number of uses of 
decr/incr so as to ensure ongoing compatibility during deprecation.

----


> Deprecate Order incr/decr for asc/desc
> --------------------------------------
>
>                 Key: TINKERPOP-1956
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1956
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: process
>    Affects Versions: 3.3.2
>            Reporter: stephen mallette
>            Assignee: stephen mallette
>            Priority: Minor
>              Labels: deprecation
>
> {{Order}} uses {{incr}} and {{decr}} which aren't terribly standard sounding 
> names for query languages where folks are more used to seeing {{asc}} and 
> {{desc}}. Deprecate the old terms in favor of these new ones. Since {{incr}} 
> and {{decr}} are in wide usage now, we might not be in a rush to remove them 
> completely any time soon - but that's a separate discussion.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to